Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

refactor: callbacks -> async/await #89

Merged
merged 8 commits into from
Jul 15, 2019

Conversation

dirkmc
Copy link
Contributor

@dirkmc dirkmc commented Mar 13, 2019

BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await

Depends on:

BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dirkmc !

Just left a minor request

src/index.js Show resolved Hide resolved
src/index.js Outdated Show resolved Hide resolved
@alanshaw
Copy link
Member

@dirkmc can you fix the cov so we can now get this merged?

@dirkmc
Copy link
Contributor Author

dirkmc commented Jul 15, 2019

I'm not sure how to read these codecov numbers. It looks like coverage has increased 10.21% but somehow codecov/patch is at 75%?

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a small detail on the docs for interval

src/index.js Outdated Show resolved Hide resolved
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vasco-santos vasco-santos merged commit 77cfc28 into libp2p:master Jul 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants